We use cookies to improve your experience. No personal information is gathered and we don't serve ads. Cookies Policy.

ExpressionEngine Logo ExpressionEngine
Features Pricing Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University
Log In or Sign Up
Log In Sign Up
ExpressionEngine Logo
Features Pro new Support Find A Developer
Partners Upgrades
Blog Add-Ons Learn
Docs Forums University Blog
  • Home
  • Forums

New Extension: MX Custom Tabs

Development and Programming

Nicolas Danhiez's avatar
Nicolas Danhiez
12 posts
16 years ago
Nicolas Danhiez's avatar Nicolas Danhiez

When custom tabs is activated with wygwam, I’ve got a js error : /themes/wygwam/lib/ckeditor/ckeditor.js:103TypeError: Result of expression ‘p’ [null] is not an object. Do you have an idea ? Thanks

       
fjldude's avatar
fjldude
50 posts
16 years ago
fjldude's avatar fjldude

Thanks for the update. So far it has been mostly positive for me. The horizonal rules are fixed. The UI is very nice. The Publish Page Index is helpful to.

BUT the update has introduced a critical new problem. My field order is being violated within the tabs for my largest weblog, which has 61 custom fields. Some fields that should appear at the top of the page within a tab are not there; instead, they are lower on the page. Curiously, most of the fields are in the correct order. I haven’t yet determined a pattern to the weird ordering. It doesn’t match my field order, nor the order listed on the settings page for MX Custom Tabs.

Hopefully this is just some new ordering/sorting bug. Alternatively, could it somehow been caused when updating?

Any help would be appreciated. If I can’t resolve, i’ll roll back to the prior version Thanks.

       
Max Lazar's avatar
Max Lazar
341 posts
16 years ago
Max Lazar's avatar Max Lazar

2Tambour Battant - could you please try version 0.7.1. Is beta version without using js.

2fjldude weird. Is no problem with order. Did you resetup you tabs? If not - don’t do it now, because new version is not taking old setting - I’m working on it at this moment.

       
fjldude's avatar
fjldude
50 posts
16 years ago
fjldude's avatar fjldude

My process: I disabled the extension, enabled it, and setup my tabs again. I even tried disabling and re-enabling again, but still having strange ordering.

I also checked the exp_extensions mysql table. All seems fine, the MX Custom Tabs settings do indeed disappear when disabling and new ones are marked with the current version.

Part of the issue might relate to my resetting of the field order several times for this weblog with more than 60 custom fields?

BTW, using latest build 1.6.8 Build: 20100121

       
fjldude's avatar
fjldude
50 posts
16 years ago
fjldude's avatar fjldude

OK, I’ve cleaned out everything and started over with the new version.

The publish page ordering is still not what I expected, nor what I had been getting with the previous version of MX Custom Tabs.

However, the ordering results of the new version do seem to be consistent. On both the publish page and the MX Custom Tabs extension settings page, the order is based on custom field ID.

But I need my tabbed publish page to accurately reflect the field order that I’ve set, which indeed varies quite a bit from the field ID order. I’m pretty sure the prior version of MX Custom Tabs followed my field order, not the order of the field ID numbers…

Make sense?

       
Max Lazar's avatar
Max Lazar
341 posts
16 years ago
Max Lazar's avatar Max Lazar

fjldude could you please try version 0.7.2.

p.s. is not needed to disable a previous version (0.7.0)

       
fjldude's avatar
fjldude
50 posts
16 years ago
fjldude's avatar fjldude

0.7.2 seems to have fixed everything for me. I’ll do more definitive testing later, but the first pass looks good.

Thanks again for a great extension… and for the speedy responses. I applaud your efforts to share so much of your expertise and time with the EE community!

       
Nicolas Danhiez's avatar
Nicolas Danhiez
12 posts
16 years ago
Nicolas Danhiez's avatar Nicolas Danhiez

Yes ! works with wygwam now ! Should I upgrade to 0.7.2 ? Thanks a lot

       
Max Lazar's avatar
Max Lazar
341 posts
16 years ago
Max Lazar's avatar Max Lazar

yes - if you want. It’s 0.7.1 with custom fild order fix.

       
Jarrett Barnett's avatar
Jarrett Barnett
31 posts
16 years ago
Jarrett Barnett's avatar Jarrett Barnett

Great job! This cleans up a lot of the clutter that was created by creating custom fields that override “Structure module” settings. Thought I was going to have to modify Structure to incorporate the fields I wantedin the Structure tab.

       
Jarrett Barnett's avatar
Jarrett Barnett
31 posts
16 years ago
Jarrett Barnett's avatar Jarrett Barnett

Hello Max,

First off, great extension!

Anyhow, I thought I should mention to those who get the “Blank Screen of Death” on their entries (after enabling and setting up tabs in MX Custom Tabs extension settings).

When using Gypsy (great add-on by Brandon Kelly http://brandon-kelly.com/gypsy) in combination with MX Custom Tabs, you have to make sure that channels/weblogs cannot have “custom field groups” assigned to them… or to ensure that any custom fields from a weblog assigned custom field group are NOT ALSO assigned via Gypsy.

Otherwise you’ll notice that there are duplicate custom fields in the MX Custom Tabs extension settings when a weblog has custom field groups assigned where custom fields are also assigned via Gypsy.

Basically, don’t have a custom field assigned twice (using Weblog Custom Field Group assignment and Gypsy assignment)

Hope that makes sense!

– Maybe some logic can be added to MX Custom Tabs to check whether a custom field has already been outputted (in the settings) to prevent this from happening… but then again custom fields shouldn’t be assigned twice anyways and is bad form anyways.

       
Wes Rice's avatar
Wes Rice
103 posts
16 years ago
Wes Rice's avatar Wes Rice

Is there any way to move my custom tab before the revisions tab if I have revisions enabled?

       
Max Lazar's avatar
Max Lazar
341 posts
16 years ago
Max Lazar's avatar Max Lazar

lockwesmonster you need to play with Publish Page index setting for you weblog.

       
NKT com's avatar
NKT com
124 posts
about 16 years ago
NKT com's avatar NKT com

Sadly it just causes a blank page for me in the publish tab if i open a weblog which has fields in tabs :(

I upgraded from 0.5.1 which was working fine.

Am also using these if it helps.

Publish Page Improvements (v.2.0.1) FieldFrame (v.1.4) Toggle Fields (v.1.0.1) Category Checkboxes (v.1.1.5) Gypsy (v.1.0.6)

       
NKT com's avatar
NKT com
124 posts
about 16 years ago
NKT com's avatar NKT com

Updated jQuery for CP and disabled and reenabled extension. Works now.

       
1 2 3 4

Reply

Sign In To Reply

ExpressionEngine Home Features Pro Contact Version Support
Learn Docs University Forums
Resources Support Add-Ons Partners Blog
Privacy Terms Trademark Use License

Packet Tide owns and develops ExpressionEngine. © Packet Tide, All Rights Reserved.