EE.cp.cleanUrl breaking CP links

Greg, that’s weird. It should be turning your URLs into something like:

http://expressionengine/system/index.php?/cp/addons_modules/show_module_cp?module=forum&method=list_boards

How are you building your URLs?

I think we have a fix for your URLs, but are you using the BASE constant to make your urls or are you building them from scratch?

I’m seeing this issue as well.

Here is how I was building my urls

$this->base_url = str_replace('&','&',BASE).'&C=addons_modules&M=show_module_cp&module;='.$this->module;

Breaks when I pass that to a view as the action in form_open.

Thanks, David

Sorry - My issue was unrelated and had to do with my redirect after posting.

I think we have a fix for your URLs, but are you using the BASE constant to make your urls or are you building them from scratch?

Yeah, we use that the majority of the time in the CP.

Wes’s change in the release should address the URL example you had, but do you have any ideas how the session ID was being placed after D=cp?

Hi Greg,

I would also be curious as to what was happening here, why the manual link construction?

Greg, anything? We really want to help you guys finish knocking out your list.

Hey sorry, I wasn’t getting email updates for this topic for some reason and just saw it towards the top while digging through the 2.8.2 stuff.

There was some reason we had to do a lot of these manually. Lemme check into it to make sure what it was and i’ll get back to you.

Greg, just nudging you to see if you have anything we need to look into here.

Hey Wes,

Thinking on this I am remembering loosely that the error building the CP links like:

ee()->config->item('cp_url').'?S='.$s

is that our end users weren’t consistent on using the CP url and some were using site.com/admin.php while others were using /system/index.php. Meaning same set of end users, same website, even with user education, some would still go to one link and some the other.

Thus when building ajax links, it was at times failing for some of our customers because they too would set the CP url to one thing then use the other option and cause JS errors because the JS domain wasn’t set.

In the end it was easier to build our own urls manually using the file they were currently visiting (admin.php vs /system/index.php) and route all links and ajax urls in kind.

There is a sidelong issue with trying to send form variables VIA $_GET to a url that already has $_GET variables on it. It doesn’t work properly unless all of the variables are in the form, hence all of the CP $_GET vars have to be written in as hidden inputs. (This situation usually occurs with filtering and pagination on MCP pages for addons.)

I should add this was also an issue because many people still don’t understand the difference between www.website.com and website.com.

Thus when building ajax links, it was at times failing for some of our customers because they too would set the CP url to one thing then use the other option and cause JS errors because the JS domain wasn’t set. In the end it was easier to build our own urls manually using the file they were currently visiting (admin.php vs /system/index.php) and route all links and ajax urls in kind.

Maybe I’m misunderstanding here, but that’s exactly what BASE does:

define('BASE', SELF.'?S='.ee()->session->session_id().'&D=cp');

SELF is defined in the index.php or admin.php being used:

define('SELF', pathinfo(__FILE__, PATHINFO_BASENAME));

We were using that too, yes, but BASE is not always set. But, loose memory of the issue. Since it’s been so long since I’ve dealt with it and its kept working, I can’t remember the full extent or what version we started doing the manual link building on.