Extension - Add JS to publish page - which hook

Take a look at this hook (added in 2.1.2, I believe): http://ellislab.com/expressionengine/user-guide/development/extension_hooks/cp/javascript/index.html#cp_js_end

thanks for the post - it actually might be good fit - but my worry is that i am only doing this on the publish page, hence i would hate to continually trigger this hook when it is not needed. But i guess i could get triggered by the hook and then run my own tests - which would still be quite efficient… hmmmm

Here’s a trick I pulled to only have it activate on the publish page:

public function cp_js_end()
    {
        $this->EE->load->helper('array');
        $this->EE->load->library('security');
        
        //get $_GET from the referring page
        parse_str(parse_url(@$_SERVER['HTTP_REFERER'], PHP_URL_QUERY), $get);
        
        $output = $this->EE->extensions->last_call;
        
        //check if we're on the publish page
        if (element('D', $get) == 'cp' && element('C', $get) == 'content_publish' && element('M', $get) == 'entry_form' && element('channel_id', $get))
        {
            //do your business here
            //$output .= 'alert("blah");';

        }
        
        return $output;
    }

Hey, This is pretty much what i am doing:

if ( $this->EE->input->get('C')=="content_publish" && $this->EE->input->get('M')=="entry_form" )
{
    // STUFF
}

What is the overhead of running a hook, but then not doing anything? I am probably being overly anal!!!

The thing about the cp_js_end hook is that it doesn’t actually occur on the same page load as the cp, it’s loaded as an external script:

< script type="text/javascript" src="index.php?S=0&D=cp&C=javascript&M=load&file=ext_scripts" >

So you don’t actually have access to the originating GET variables, because it’s technically a separate request.

As for the overhead, I would personally only worry about it on the front end. It doesn’t bother me to add a few milliseconds to the CP.

ah okay, that makes more sense… i’ll have a play then and update my scripts. Thanks, N

Official response from EllisLab is $this->EE->router->class

It looks like you’d use it this way….

if($this->EE->router->class == ‘content_publish’) { do something }

I think I need more information here. Using $this->EE->router->class within the cp_js_end() hook returns the ‘javascript’ class. Am I doing something wrong?

Anyone have any issues with browser cacheing? I’m running into the problem where even if i detect a publish page, my browser will return a cached version from a prior page.