ExpressionEngine CMS
Open, Free, Amazing

Thread

This is an archived forum and the content is probably no longer relevant, but is provided here for posterity.

The active forums are here.

ExpressionEngine 1.6.5 Released

October 24, 2008 3:44pm

Subscribe [23]
  • #31 / Oct 26, 2008 4:44am

    serafico

    58 posts

    My question: how to hide the text: “Commenting is not available in this weblog entry.”, added by the system when comments are not allowed for the specific entry?

    The string that goes with this text is found in the lang.comment.php file. You could always replace that text with something else.

    Thanks for advice. You mean, I could add “p class=“hidden” for instance? 😉

  • #32 / Oct 26, 2008 4:47am

    Ingmar

    29245 posts

    Why, you could leave it blank. Or “& nbsp;” if you must.

  • #33 / Oct 26, 2008 4:54am

    serafico

    58 posts

    Yes, of course, I know. It was only an “idea”. Thanks.

  • #34 / Oct 26, 2008 5:01am

    serafico

    58 posts

    serafico, you should not have to “correct” any of your entries.  The new system will accommodate pretty much any markup you can throw at it, including using your own paragraph tags with attributes.

    And yet… I give you two examples to show the problem.

    1.

     lorem ipsum
    lorem ipsum
    lorem ipsum

    When I manually add opening and closing tags “p” at the beginning and at the end of a poem, EE 1.6.4 “understood” this and added only <break>s at the ends od the lines. The 1.6.5 seems not to recognize it and does not add anything, so the text has no line breaks.

    2.

    lorem ipsum
    
    lorem ipsum
    lorem ipsum
    
     lorem ipsum
    lorem ipsum
    lorem ipsum

    The first three lines (without any manually added formatting) are correctly formatted by 1.6.5. But when I add manually a “p class=” tag, 1.6.5 leaves the following lines without any formatting. I have to close for instance the paragraph tag manually to have the rest of the text be formatted correctly.

    And believe me, it’s not a claim, of course, I wanted only to show the difference between 1.6.4 and 1.6.5.

  • #35 / Oct 26, 2008 8:40am

    Riverboy

    2993 posts

    Came to my mind. Is there anything new with the admin.php - should i update all my masked admin.php’s now? Something else that might be important when using MSM?

    Thanks:
    - Tuittu

  • #36 / Oct 26, 2008 9:27am

    Linda A

    666 posts

    Is the option to leave uppercase letters in url titles automatically active or is it a preference one turns on? 😊

    Thank you so much for that one, btw. 😊

  • #37 / Oct 26, 2008 6:06pm

    lebisol

    2234 posts

    Thanks for the update, as always it went without issues.
    😊

  • #38 / Oct 27, 2008 7:41am

    Dom Stubbs

    156 posts

    Thanks for the {redirect} function - that’s been on my wishlist for a very long time.

  • #39 / Oct 28, 2008 10:54am

    My question: how to hide the text: “Commenting is not available in this weblog entry.”, added by the system when comments are not allowed for the specific entry?

    The string that goes with this text is found in the lang.comment.php file. You could always replace that text with something else.

    Three things about this:

    1. The message is inserted without any HTML, so in my case it is inserted without any of the margin/padding applied to paragraph text. Would it not be better to wrap automatically generated code in a paragraph tag so it is less likely to break any design?

    2. I now need to go in and hack the lang.comments.php file for several sites and will need to remember to do this every time there is an update.

    3. What is the reason for the compulsory displaying of a message if comments had been turned off for an entry?

    I have always used the {if allow_comments} conditional which seems to work fine and gives me the control to display a message if I want, what’s the problem with this option?

  • #40 / Oct 28, 2008 11:51am

    Derek Jones

    7561 posts

    Prior to this update, you would get that message when commenting had expired, but not when commenting was disabled at either the weblog or the entry level.  This change was to make the behavior consistent across the board, and was actually in response to a number of requests and individuals reporting it as a bug.

  • #41 / Oct 28, 2008 12:32pm

    Prior to this update, you would get that message when commenting had expired, but not when commenting was disabled at either the weblog or the entry level.

    I know, I have had to hack the language file to add the correct message for some time.

    The language file still has:

    "Commenting is not available in this weblog entry."

    for when commenting has expired, shouldn’t the default be:

    "Commenting has expired for this entry."

    This needs to be dynamic and cut in when the date is reached.
    The decision not to allow commenting at the time of publishing is selectable and so doesn’t need an automatic message.

    Part of my problem is that I only allow commenting on a small number of posts and the new code makes it sound like I’ve taken away something that is normal.

    What about my problem with the inserted message not being within a paragraph tag?
    I can’t style the message because it’s not there in the template.
    I don’t want to define body text in the CSS to have padding/margin as that will mess up the rest of the design.

    I accept that you can’t please all the people all the time, but why wouldn’t you want the inserted message to be within a paragraph tag?

  • #42 / Oct 28, 2008 12:45pm

    Derek Jones

    7561 posts

    I agree, the behavior could be better - for this particular update the goal was simply to make the behavior consistent.  Feel free to pop over to the Feature Request forum with your suggestions.  In the meantime, you could put a <div> around your comment form, and use CSS/Javascript to style it or hide it as you see fit.

  • #43 / Oct 28, 2008 1:23pm

    I already have the comment form in a <div>, but I add margin/padding to the elements within it rather than to the container (helps with box-model problems in IE).
    So this will require a major re-write of my CSS or a hack to the language file.

    Am I right in thinking that the same message is called if either comments have been disabled or expired?

    If so, then I can’t hack the language file to hide the message, as posts that do have expired commenting will not get the message.

    I guess the Feature request should be for additional conditionals to handle these what ifs.
    {if_comments_disabled}
    {if_comments_expired}

  • #44 / Oct 28, 2008 1:41pm

    Derek Jones

    7561 posts

    You should be able to use inheritance to your advantage.  Yes, the same message is used.

  • #45 / Oct 28, 2008 1:49pm

    grrramps

    2219 posts

    BTW, noticed that EE is up to build 20081028, just one day after I updated all my sites to build 20081024.

    Sigh.

    Is there a way we could get the good folks at EE to provide a change log with each build? Or, have an official announcement of each new build with the change log?

    Thanks…

.(JavaScript must be enabled to view this email address)

ExpressionEngine News!

#eecms, #events, #releases