Hi, I found a problem (at least, for my app, it was a problem 😛) with loginr function (in the ion_auth_model).
If an user choose “remember me” and the really bad administrator deactivate his account, he still can do auto login. The solution I found is just to put “->where(‘active’, 1)” in the select query at line 930. I know I could just use an _extra_where, but I think it’s more secure doing this way.
$query = $this->db->select($this->identity_column.', id, group_id')
->where($this->identity_column, get_cookie('identity'))
->where('remember_code', get_cookie('remember_code'))
->where('active', 1)
->limit(1)
->get($this->tables['users']);
I made another modification, I’m using ci encrypt class to protect the identity and remember_code cookies’ values. Maybe it’s excess protection, but, I think this couldn’t be exposed.
It’s a really good library, I was using a modified (by me) version of redux_auth, but I really liked this lib. Now I’m modifying a little this lib to works with my app, but it was so well structured that I almost have nothing to modify :cheese: .
Congratulations, and thanks for the lib.