Bug #23066 See Comments

Shared Table View - Action Buttons

Version: 3.5.3 Reporter: szgalbraith

Adding more than one action button through the table service ends the column.

Line 214 of system/ee/EllisLab/ExpressionEngine/View/_shared/table.php should not have the </td> after the <a> block within the foreach loop.

  • Hi,

    Are you referring to the table action row? https://ellislab.com/style-guide/c/listings#actions-row

    If yes, there should never be more than a single action available here.

    James Mathias
    17th April, 2017 at 9:05am
  • I am referring to the code on Line 214 of system/ee/EllisLab/ExpressionEngine/View/_shared/table.php.

    <?php if ( ! empty($action_buttons) || ! empty($action_content)): ?>
        <tr class="tbl-action">
         <td colspan="<?=$colspan?>" class="solo">
          <?php foreach ($action_buttons as $button): ?>
           <a href="http://<?=$buttonurl">?>"class="<?=$button['class']?>" ]<?=$button['text']?></a></td>
          <?php endforeach; ?>
          <?=$action_content?>
         </td>
        </tr>
       <?php endif; ?>

    The foreach loop has a extra </td> within the loop. The Table Service allows for multiple action buttons to be added and this seems furthered by the foreach loop that calls that array. In any event, the </td> may cause style errors if more than one button is added.

    szgalbraith
    17th April, 2017 at 10:48am

You must be signed in to comment on a bug report.

ExpressionEngine News

#eecms, #events, #releases