ExpressionEngine CMS
Open, Free, Amazing

Thread

This is an archived forum and the content is probably no longer relevant, but is provided here for posterity.

The active forums are here.

Github and the need to submit a pull request to get anything looked at is a PAIN

September 20, 2011 12:49am

Subscribe [1]
  • #1 / Sep 20, 2011 12:49am

    skunkbad

    1326 posts

    Every time I suggest something on uservoice that seems to have any interest, I get told to submit a pull request, which is a pain because although I have tried, I’m not familiar enough with Github or Git to know if I did it right. I had originally forked CodeIgniter and submitted a pull request for something, then I wanted to make some changes to the upload class:

    https://github.com/skunkbad/CodeIgniter/commit/3fb2de553ce7744c9f40a3be08dde86b36cd9fb2

    When I made the changes, I tried to submit a pull request, but it said I had already done that, and asked if I wanted to amend the pull request. I said yes, but not sure if that was the right thing to do. How does a person submit two or more pull requests that don’t have anything to do with each other?

    I wish somebody could just take a look at:

    https://github.com/skunkbad/CodeIgniter/commit/3fb2de553ce7744c9f40a3be08dde86b36cd9fb2

    and tell me. I don’t have a lot of time to play around with Github/Git, especially when I won’t use it except for CodeIgniter pull requests, so any help is appreciated.

    Are all feature requests handled entirely through pull requests on Github? I’d like to participate in making CI better, but my frustration and confusion with Github/Git makes it hard for me. I wish there was another way.

  • #2 / Sep 20, 2011 9:31am

    danmontgomery

    1802 posts

    With 69 current pull requests, 286 issues and and over 250 forks, yes, pull requests are necessary. You can’t expect someone to seek out every fork for new changes, then manually re-write those changes to pull them into the core. There is some very helpful documentation available:

    http://codeigniter.com/news/contribution_guide/
    http://help.github.com/send-pull-requests/

.(JavaScript must be enabled to view this email address)

ExpressionEngine News!

#eecms, #events, #releases