Thread

I’ve just implemented the Edit Comments plugin on my site. While playing with it on my test site, I noticed a couple of things:

First, a small bug. If you implement the time limit (15 minutes by default), then the edit link is correctly hidden from the user’s comments, but the edit-box div is still output. Hence you wind up with (hidden) extra stuff on the page for no good reason. Not a huge issue, but I wanted to clean it up. I fixed this in my version by adding the timeout check to the query for the wrap part too. I’d be glad to send you guys the fixed-up version if you tell me where to send it.

Second - is there any to implement the HTML Formatting buttons for the comment editing box? Nothing obvious leaped out at me.

Lastly, it would be nice if the timeout and moderator-groups could be implemented as tags parameters rather than hard-coded variables. Since they’re used in two different tags, they’d have to be passed twice, but you could set them in a template global and just reuse that. To me, this is much preferable to editing code to change the time limit. It would also allow different time limits and/or moderators in different sections of a site. I can implement that in my version pretty easily, but I wanted to see if you had any thoughts on this first.

Thanks much.

So, this is a bug report, of sorts, and two feature requests? Any questions for Tech Support? 😊 That said, I don’t see an obvious way to incorporate the HTML Formatting buttons, either.

So, this is a bug report, of sorts, and two feature requests? Any questions for Tech Support? 😊 That said, I don’t see an obvious way to incorporate the HTML Formatting buttons, either.

Well, you could say it’s a bug report, a tech support question and a feature request all rolled up in one, with a bonus helping of a fix for the bug if you want it.

Dwex:

Can you please post your Feature Request in the Feature Request forums, and we are looking into the bug report as well.

Thanks,

-greg

Thanks for the report, dwex.  I’m going to hold off on the div issue for the moment and consider the whole ball of wax at one time, since it sounds like you’re good with your current modification and it’s not impeding the functionality at the moment.

That sounds fine. Do you still want me to submit a separate post in the Feature Request forum as Greg suggested? And would you like me to send you a copy of my edited version of the plugin?

Thanks.

Hrm- is torn.  I did make a note and a link back in my ‘notes’.  But the FR is still probably a good idea.  Never know- others may have some thoughts to chime in as well.

I think I’m ok w/out the file as when I get to it I’ll take a step back and ponder the whole thing anyway.  But I will yell if I change my mind when the time comes 😉.

OK, will do.

Thank you. In the meantime, let me mark this thread as “Resolved”. Please don’t hesitate to post again as needed.