Thread

Build: 20100810

Whenever I post or edit a channel entry that has a entry/expiration date after 31st October when DST ends (UK), the time within the date is automatically decreased by 1 hour.

E.g. I post a date of 2010-11-06 12:00 it will save as 2010-11-06 11:00

I have the following settings;

TimeZone: UTC
Daylight Saving Time: No
Honor the Daylight Saving Time setting associated with each channel entry? No
User localisation settings > Daylight Saving Time: No

I’m using expression engine to run an events calendar, so the time of the event is really important.

Is there anything I can do to make posts ignore the DST settings and just keep the time that is entered into the post?

Thanks for the help in advance.

John

I am having the same issue. I was going crazy and thought it was my system.

I have updated the system/expresionengine/fieldtypes/ft.date.php file so the save function looks like this

function save($data)
    {
        if ($data != 0 && date("I",$data) == 0){
            $data = mktime(date("H",$data)+1,date("i",$data),date("s",$data),date("n",$data),date("j",$data),date("Y",$data));
        }
        return $data;
    }

It appears to be working.

I need to test what happens after the system date is when daylight savings is off, but this will hold you over for a month or so.

edit… code was bad :(

Hi jstewart,

In Admin > Localization Preferences, what is set for Honor the Daylight Saving Time setting associated with each channel entry? Have you tried toggling this to see if it helps?

Hi Brandon,

‘Honor the Daylight Saving Time setting associated with each channel entry?’ Is set to ‘No’ toggling it to ‘Yes’ doesn’t change anything. Dates posted after DST ends on the 31st of October decrease by one hour each time they are added or edited.

John

I have tried every combo possible. I am guessing that since Daylight saving toggles have no effect then that is the problem. I believe the error lies in

$this->EE->localize->some_date_function_that_is_doing_dst_changes_wrong();

If you would like to tell me what file this code resides in I would be more than willing to try a “fix” - and not a hack like my code above.

hah - I’m having this problem too.  Glad its not just me!

Ok, well I think I found the issue and I would like feedback. Below are lines 470 through 487 of system\expressionengine\libraries\Localize.php It appears that this code is what is messing things up and it appears that this is “intentional” as the comments say exactly what happens yet we don’t want it to happen.

// Offset the time by one hour if the user is submitting a date
        // in the future or past so that it is no longer in the same
        // Daylight saving time.    

        if (date("I", $this->now))
        { 
            if ( ! date("I", $time))
            {
                $time -= 3600;            
            }
        }
        else
        {
            if (date("I", $time))
            {
                $time += 3600;            
            }
        }

I changed the file to look like this and all it well (be sure to take my above hack out of your code)

// Offset the time by one hour if the user is submitting a date
        // in the future or past so that it is no longer in the same
        // Daylight saving time.    

        /*
        if (date("I", $this->now))
        { 
            if ( ! date("I", $time))
            {
                $time -= 3600;            
            }
        }
        else
        {
            if (date("I", $time))
            {
                $time += 3600;            
            }
        }
        */

Looks like you are all running into the date bug which was reported and confirmed here

There are some case scenarios from users within the comments of that report. It looks like your particular case above matches a few. Can you confirm this?

Looks like you are all running into the date bug which was reported and confirmed here

There are some case scenarios from users within the comments of that report. It looks like your particular case above matches a few. Can you confirm this?

That does not appear to be the same bug.

Thank you for your feedback, rjsteck. The issues surrounding time/date and DST are being revisited for the bugfix John pointed to.

Thank you for your feedback, rjsteck. The issues surrounding time/date and DST are being revisited for the bugfix John pointed to.

Thank you, I will work through that thread to get the issue resolved.

Just to add to this thread.. we’re going to be thoroughly testing date/time issues before the next build/version is released. We appreciate your patience.

Has this been fixed yet?

No, as this is a somewhat complex issue. You can read more about it here.

Is there a work-around to the “one hour rollback” problem for new sites?  I have a site launch hanging on this issue.