I’m starting a new thread because the other one is far too long.  I figured the best way to kick off a new thread would be with a new release.  I know it has been a while since the last release - hopefully the fixes and new features will satisfy.  (Actually, it was SurfTasmania who is responsible for motivating me to get this release out.  Thanks for the show of support, friend.)

EEpoll, Release 1.4

Version 1.4 Change List:

- Incorporated csv export (Douglas Lorenz) into primary dev trunk
- Fixed cvs export error (export on poll without results)
- Added new vote option: Vote Order (Fixed or Random)
- Added new result option: Result Order (Fixed, Asc, Desc or Random)
- Repaired poll_id=‘latest’ query
- Tried a new approach on query for poll_id=‘random’
- Poll answers may now safely contain commas
- Email address length is now 100 characters
- Poll closure date should now take localization into account (needs testing!)
- Redirection issue fixed (used to go to index which was why votes were lost sometimes)
- Custom redirection now available {exp:eepoll target=“URL”}
  (Caution: the URL *MUST* go to a page with the poll on it for votes to register!)
- Repaired issue in the recalculation code which was causing garbled results
- New poll option: Show Total Votes (displays vote total underneath poll name)
- New module config option: Total Votes Label (prefixes vote total)
- New CSS class: pollTotalVotes
- Control Panel poll detail now shows total votes (always shows)

This is mostly bug fixes and yes, there were nearly as many as we get each spring here in SE Texas.

Notable changes:
The redirection change is the biggest one.  I’m pretty sure this is the cause of most of the ‘my poll is not working’ complaints.  Custom redirect is also now available but be forewarned - if your redirect does not go to a page showing the poll they just voted on, then the vote will NOT be counted.

***Special thanks to Douglas Lorenz for the nifty CVS export.

Issues I did not address:
+ CSS Control of bar color
I just didn’t see this as necessary.  A stylesheet for the colors would be a static implementation and I’m already offering that in the module configuration.  Plus there just is not an elegant way to do it.  Why add 15 bar styles when you can just configure a string in the module config and be done with it?

+ ID vs CLASS issue.
I could not find ANYWHERE that I was still using ID.  If you find one, let me know ASAP and I will do a quick mod to this release.

+ List of polls / show all polls (and paginated no less!)
This would take some work and I figured people would want the bug fixes more than waiting for me to hack out this kind of feature.  (Honestly, I don’t have time right now to beat on this but it has been added to the future enhancements list.)

Have fun with it and I’ve little doubt you will fail to tell me about any bugs or shortcomings!

KoF

= = = = =

FYI: The latest release of EEPoll is: EEPoll 1.7

+ CSS Control of bar color
I just didn’t see this as necessary. A stylesheet for the colors would be a static implementation and I’m already offering that in the module configuration. Plus there just is not an elegant way to do it. Why add 15 bar styles when you can just configure a string in the module config and be done with it?

Because if you have skins, you’d be able to fully control what the bar colour looks like for each skin.

Grrrr. I’m trying to counter your argument, but I can’t think of anything bright.  (Maybe I should sleep, instead!)  If I can’t think of a good counter by this afternoon I will see how much work it is to eek that change into the mod. 

(What were you thinking as far as class goes…right now there is already a class applied to each bar, but the style colors override it.  Is disabling the colors enough of a help or do you need a class for each bar, as in Bar1, Bar2, Bar3, etc.)

Great work, I will try this release later and report if anything out of the ordinary occurs!

Many thanks!

I should have some time tomorrow to install this, looks like some good changes. Thanks for the great work here.

No worries mate! You deserve the support - well done answering the call and tackling this module for the greater good!

. . . . just upgraded

BTW - I assume these errors on upgrade itself are “OK” / “normal” ?

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/xxx/public_html/xxxx/db/db.mysql.php on line 316

Warning: mysql_free_result(): supplied argument is not a valid MySQL result resource in /home/xxxx/public_html/xxxx/db/db.mysql.php on line 326

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/xxxx/public_html/xxxx/db/db.mysql.php on line 316

Warning: mysql_free_result(): supplied argument is not a valid MySQL result resource in /home/xxxxx/public_html/xxxx/db/db.mysql.php on line 326

wooops . . . might be best for others to note in future that posting in public such errors in their full glory isn’t the most secure way to deal with ones EE site!

DoH!

=(

squillo from the earlier thread:
After I voted, then logged off, then turned off “Check IP” and “Use Cookies”, it still wouldn’t display the poll (only the results). In itself that’s not a big deal, but each time I reloaded the page (not signed in) it tallied another vote.

KoF:
Were you logged in as an EE member? The module always limits voting by member so if you were logged in and voted, it should prevent you even with the other two methods disabled - at least until you removed your vote.

I reproduced the behavior, sort of, and it’s probably not worth worrying about.  I wasn’t logged in as a member, but it does offer “All Users” as a Voting Mode, right? That, in combination with CheckIP and Use Cookies off, could certainly explain the behavior I saw the first time. 

Can’t wait to install 1.4.  Urok.

Surf…I will go back and test the upgrade routines.  I never got around to working them over.

I am also getting four errors when I upgrade from 1.3 to 1.4 BUT I am examining the databases and everything is being converted properly.

It looks like the EE db.mysql.php library always builds an array from the result of a query and it does not like either the DROP table queries or the RENAME and CREATE table queries.  (Create works fine on a new install so I think the DROP is problematic.)

As long as all you see are Warnings and if the version number changes to 1.4, you are fine.

KoF, can I request something that should take you only a few seconds?  Bundle the documentation and make a link to it from the front page of the EE Module panel?  I can’t ever find it when I need it, and that would really help. :(  Preferably bundled, and not an external link.

Give me a link to the wiki docs and I will.

Er, what’re you talking about? What wiki docs, and why?

KoF - hadn’t the chance to test the new release ... but wanted to express my thanks for your continuing efforts (and the new thread, of course .

Thanks a lot - keep on!

-Markus

At your service, Markus.

LisaJill, try downloading and installing the module again and then clicking the new “Usage and Tips” option at the main menu.  Is that what you had in mind?

KoF - I don’t want to have each bar a different colour.

I assume that by simply removing the style=whatever from the img tag of the PollBarImage, that it would then fall grab the formating from the PollBarImage class declaration in the CSS file.

Is there a way to say ... actually, I wonder ...

If I was to leave the Bar Color Configuration box empty, would it then grab the style from the stylesheet? Or would it default to whatever was setup in my poll configuation?

let’s give it a try…

OOOOH! It worked! it Worked!!

All one needs to do is keep the Bar Color Configuration box of the actual poll empty and it then pulls from the CSS info.

Gotta love simple workarounds!

I love that kind of work around also!!!

I’ll download ina moment, but yes that’s what I had in mind.  Now I don’t have to search out the docs. thank you. =)

...especially since the docs are strung out in random fashion down a 250+ post thread.

(Although adding that feature took several orders of magnitude longer than your estimate…but it will pay off down the road.)