XML-RPC : xss_clean not respecting weblog settings
Posted: 08 August 2008 04:56 PM   [ Ignore ]  
Summer Student
Total Posts:  4
Joined  08-08-2008

As reported initially on http://codeigniter.com/forums/viewthread/80473/

A patch is included in the original post.

IMHO the XML-RPC engine should respect the user’s settings for XSS protection, or allow another setting to control this. Any users of remote weblog editors will be very confused as to why their embeds work when pasted into the web editor but not when sent through the program.

Profile
 
 
Posted: 08 August 2008 05:03 PM   [ Ignore ]   [ # 1 ]  
Administrator
Avatar
RankRankRankRankRankRankRank
Total Posts:  15833
Joined  06-03-2002

I can see the argument for CI, but in ExpressionEngine, we take a very firm stance that any input that comes from outside of the control panel (say, via the Blogger API) is subject to extra scrutiny.

 Signature 
Profile
MSG
 
 
Posted: 08 August 2008 05:55 PM   [ Ignore ]   [ # 2 ]  
Summer Student
Total Posts:  4
Joined  08-08-2008

Thanks for the clarification, Derek.

What would you suggest we recommend for users of our application who wish to post embedded content through the application? I found one plugin for youtube, but am a bit skittish about recommending an unofficial plugin for our users.

Profile
 
 
Posted: 08 August 2008 10:40 PM   [ Ignore ]   [ # 3 ]  
Administrator
Avatar
RankRankRankRankRankRankRank
Total Posts:  15833
Joined  06-03-2002

The YouTube/Google Video plugin that was written by a community member is pretty safe, the developer had input from us to make sure things were buttoned down.  He just hasn’t submitted it to the repository for one reason or another.

My personal opinion is that things such as embed / object tags never belong in entries; that belongs in a template, and the content author would be entering into a field simply a URL, or in the case of YouTube, a unique identifier that the template constructs the URL from.  This is a design pattern that I follow of separating presentation from content, and in this case has the added affordability of security, and not asking content authors to understand the obtuse embed/object markup.

 Signature 
Profile
MSG
 
 
   
 
 
Post Marker Legend
New Topic New posts Hot Topic Hot Topic with new posts New Poll New Poll Moved Topic Moved Topic Sticky Topic Sticky topic
Old Topic No new posts Hot Old Topic Hot Topic with no new posts Old Poll Old Poll Closed Topic Closed Topic Announcement Announcements
Theme
Change Theme
Visitor Statistics
The most visitors ever was 1149, on July 16, 2007 09:33 AM
Total Registered Members: 64939 Total Logged-in Users: 57
Total Topics: 81911 Total Anonymous Users: 52
Total Replies: 440323 Total Guests: 300
Total Posts: 522234    
Members ( View Memberlist )