Hi Sambo,

Sorry to keep you bothering . Your Plugin seems to be THE solution to my problem. As I also have a deadline for this site, next week monday, I’m currently working day and night.

So I have made a test page:
http://www.signsofthetime.eu/test

with this code:

To demonstrate when the strange numbers come up. Really no clue what’s going on….

Erwin

Hi Sambo,
Our replies crossed. Hope previous posts clearifies my problem.
Erwin

Hi,

this is very strange because the following code works on my site:

I did notice that I was relying on PHP5 for one function in the plugin and now I have updated that.

Go and check if the updated plugin works any better.

Also make sure that exp:shj_imgmodifier is all lowercase.  I think that matters.

Best,
Sambo

Hi Sambo,

That was it! I was just the use of the capital :-(. It now works fine. Great actually!

I have also two other websites (www.mensmerk.nl and www.erwinvanlun.com) and I have been looking for a scheduled ‘nifty corners’ function for a long time. I will use this plugin for these sites as well. On top, I will also use LightBox. This will have great results. (but I do this later as I have to figure out how Lightbox works).

For now, I would like to give you three suggestions:
1)In your posting on this thread, posted: 02 March 2008 12:12 PM, you use the capital S. I just copied you code assuming it was okay. You might consider correcting this.
2) Why don’t you rename your plugin to img_modified? That’s more consistent with other plugins and EE standards.
3) Smileys in the code are also resized. Although it looks very funny, this is certainly not your intention. How could we tackle this one? Read the path for smileys and ignore smileys?

Lots of success with your plugin and thanks for your fast reactions!

Erwin van Lun - 01 May 2008 05:23 AM

3) Smileys in the code are also resized. Although it looks very funny, this is certainly not your intention. How could we tackle this one? Read the path for smileys and ignore smileys?

Haven’t used it..

Great suggestion, or we could define a certain size of image to not quality via it’s relative size. Smiley’s are small, so anything greater in height=“30” and width=“30” probably won’t need it. I can’t imagine any smiley’s being larger than that.

Erwin van Lun - 01 May 2008 05:23 AM

For now, I would like to give you three suggestions:
1)In your posting on this thread, posted: 02 March 2008 12:12 PM, you use the capital S. I just copied you code assuming it was okay. You might consider correcting this.
2) Why don’t you rename your plugin to img_modified? That’s more consistent with other plugins and EE standards.
3) Smileys in the code are also resized. Although it looks very funny, this is certainly not your intention. How could we tackle this one? Read the path for smileys and ignore smileys?

Hi,

- Yes I noticed that I used capital S in the post and also in the documentation on the website.  Sorry about that - I have fixed it now.
- I thought it might be a good idea to prefix my plugins with my initials to prevent conflicts.  Maybe it just causes problems
- I can think of several ways to solve the smiley problem but unfortunately I do not have time to implement them now. I hope I will be able to do it soon.

Good luck with your sites

Best,
Sambo

Hi Sambo,

Going on with your awesome plugin, I have found the following challenge:

http://www.signsofthetime.eu/sandbox/image_lcoal_test

In this case, the {image} tag does not come from a exp:weblog clause but from a exp:sql clause. Same statement, but then {filedir_1} is ignored. I tried to solve this with:

But this gives, unfortunately, again the ‘funny numbers’.

You plugin should actually be able to parse {filedir_x} statements.

For now, I can’t find a solution for this problem (or just by replacing all {filedir_1} by hard coded URL’s. That will help, but is not handy.

Hi,

Have you tried to add the parse=“inward” parameter to the plugin?

I think that might do the trick.

Sambo

HI Sambo,

Actually I didn’t try it (because I didn’t know it existed). In the plugin and on your website the parameter is not mentioned. I have found version 0.1 of your plugin. I’m not at all a php guru, but the parameter ‘parse’ isn’t in the ‘fetch’ list.

This is the code:

but still the same results on http://www.signsofthetime.eu/sandbox/image_lcoal_test/

Hi,

yes the parse parameter isn’t in my plugin.  I think it is something that all plugins inherit from the system.  It is a documented EE feature and changes the order of the parsing.

But the errors I see on your test page indicate that the plugin is working, but the image path isn’t correct.  PhpThumb says the image can not be found.  Have you verified that paths?

Hi Sambo,
The paths are correct, but the problem is that—within a SQL statement—the {filedir_1}tag isn’t parsed at all.

And still the funny numbers…. :-(

I have also tried this without the typography tag, it then says the picture can’t be found.

Wild guess.  Try the parse=“inward” on the sql plugin.

Maybe I need to understand better what you are trying to do.  You have a path to an image and are trying to use the plugin to create a new img tag based on your parameters?

The plugin will only do something if it finds an img tag.  Maybe you could put your image path into a img tag and see what happens.

Optimised the test page:

[code}Just Image:<br>
{image}<br><br>

XMP code :<br>
<xmp>{image}</xmp><br><br>

XMP code with ee_typography:<br>
<xmp>{exp:ee_typography allow_image_urls=“y”}{ image}{/exp:ee_typography}</xmp><br><br>

{exp:shj_imgmodifier phpthumb=“true” phpthumb_path=”/thumb/phpThumb.php” phpthumb_attributes=“q=50&zc=1” width=“420” lightbox=“false” clear=“true” parse=“inward”}
Modified image with ee_typography:<br>
{exp:ee_typography allow_image_urls=“y”}{ image}{/exp:ee_typography}<br><br>
Modified image without ee_typography:<br>
{image}<br><br>
{/exp:shj_imgmodifier}
<br><br>
{/exp:query}

On top, I have added a parameter to the ee_typography tag to allow for image URL’s. As you can see in the XMP statement, it parses fine. You can try one of the images and see that they exist. However, no images show up :-(. I really don’t know what could be the problem. Maybe a night of sleep will help…

I have tried your suggestions but also the parse inward on the SQL statement don’t work.

But browsing, browsing, browsing, I have found this solution:

http://expressionengine.com/forums/viewthread/56324/ by Sue.

Which just says: define a global var filedir_5 (in my case). This works! It is not the solution which will get an EE innovation award, but it works… And as the deadline is approaching very fast, I am really happy right now.

thanks for all your support!

Erwin

Great.  I am really glad that you have a solution.

Good luck with your deadline.

Hi Sambo,

Found a bug in your plugin shj_imgmodifier. Should I report this here or in bug forum?

The bug occur when an author inserts an image from another domain. It leads to a PHP error: division by zero error. Actually, no picture should be returned.

Erwin

Hi

Thank you for reporting it.  You should do it here.  I will look into this.

I suspect that the problem is some settings in PHPThumb. The plugin just finds img tags and modifies the tag.  It does not care if the image is on another domain or not.

Best,
Sammi