2 of 2
2
Formatting Buttons Not Working Properly in 1.3
Posted: 08 July 2005 06:26 PM   [ Ignore ]   [ # 19 ]  
Research Scientist
Avatar
RankRankRankRankRankRank
Total Posts:  7509
Joined  08-05-2002

Open it up and see if it has that function in there.

 Signature 
Profile
 
 
Posted: 08 July 2005 06:30 PM   [ Ignore ]   [ # 20 ]  
Lab Technician
Avatar
RankRankRankRank
Total Posts:  1695
Joined  05-13-2004

inside html_buttons.php liln 19-34

function create_buttons()
    
{
$this
->buttons[] = array("<b>","[b]","[/b]", "Bold Text");
$this->buttons[] = array("<i>","[i]", "[/i]", "Italic Text");
$this->buttons[] = array("<u>","[u]", "[/u]", "Underline Text");
        
    if (
$this->allow_img == TRUE)
    
{
    $this
->buttons[] = array("<img>", "[img]", "[/img]", "Image Link");
    
}
    
$this
->buttons[] = array("quote", "[quote]", "[/quote]", "Quoted Text");
$this->buttons[] = array("code",  "[code]",  "[ /code]", "Code Example");
    
ob_start();
?>

 Signature 

CreateSean Web Design
CreateSean - My journey to pro web designer
I am the poster formally known as The Linguist.

Profile
 
 
Posted: 08 July 2005 09:23 PM   [ Ignore ]   [ # 21 ]  
Research Scientist
Avatar
RankRankRankRankRankRank
Total Posts:  7509
Joined  08-05-2002

Man, I thought I replied to your comment three hours ago, sorry.  Um, well, it looks like it should be working then.  No other PHP errors?  Perhaps your drugged the plugin and it is just confused?

 Signature 
Profile
 
 
Posted: 08 July 2005 09:49 PM   [ Ignore ]   [ # 22 ]  
Lab Technician
Avatar
RankRankRankRank
Total Posts:  1695
Joined  05-13-2004

That’s okay, I went out for 3 hours and just got back. Anyhow I’m leaving for a week in Singpore and will check this out at that time. Hopefully I’ll be able to fix it then.

 Signature 

CreateSean Web Design
CreateSean - My journey to pro web designer
I am the poster formally known as The Linguist.

Profile
 
 
Posted: 09 July 2005 05:32 AM   [ Ignore ]   [ # 23 ]  
Research Assistant
Avatar
RankRankRank
Total Posts:  758
Joined  09-27-2004

is a way to change the names from the buttons (comments plugin)?

Profile
 
 
Posted: 09 July 2005 06:00 AM   [ Ignore ]   [ # 24 ]  
Lab Assistant
Avatar
RankRank
Total Posts:  209
Joined  01-10-2004

Not a huge deal, but when it’s installed it still shows the old name rather than the new Comment HTML Formatting Buttons name.  Probably the two should match otherwise poor people might get confused smile

 Signature 

bryan | website

Profile
 
 
Posted: 09 July 2005 06:04 AM   [ Ignore ]   [ # 25 ]  
Research Assistant
Avatar
RankRankRank
Total Posts:  758
Joined  09-27-2004

the two?

Profile
 
 
Posted: 09 July 2005 06:10 AM   [ Ignore ]   [ # 26 ]  
Lab Assistant
Avatar
RankRank
Total Posts:  209
Joined  01-10-2004

The two names.  The name of the plugin changed however it was never updated in the file so when installed is shows the old name.  I changed it for myself, but it should probably change in the download as well so people don’t get confused.

 Signature 

bryan | website

Profile
 
 
Posted: 09 July 2005 06:30 AM   [ Ignore ]   [ # 27 ]  
Moderator
Avatar
RankRankRankRankRankRankRank
Total Posts:  12779
Joined  04-29-2002
schweb - 09 July 2005 06:10 AM

The two names.  The name of the plugin changed however it was never updated in the file so when installed is shows the old name.  I changed it for myself, but it should probably change in the download as well so people don’t get confused.

Yes, I noticed that. smile You’re right, it would be better to change it.

 Signature 

Quick Reference - EE Trial Options - EE Wiki - Docs for updating a build

Profile
MSG
 
 
Posted: 09 July 2005 06:36 AM   [ Ignore ]   [ # 28 ]  
Moderator
Avatar
RankRankRankRankRankRankRank
Total Posts:  12779
Joined  04-29-2002
frontflash - 09 July 2005 05:32 AM

is a way to change the names from the buttons (comments plugin)?

You’d need to modify the html_buttons.php file in the /system/lib folder

 Signature 

Quick Reference - EE Trial Options - EE Wiki - Docs for updating a build

Profile
MSG
 
 
Posted: 09 July 2005 06:52 AM   [ Ignore ]   [ # 29 ]  
Research Assistant
Avatar
RankRankRank
Total Posts:  758
Joined  09-27-2004

ok. there i found the button names. only i can not find the @ (email) <a>(link) buttons. ideas?

Profile
 
 
Posted: 09 July 2005 11:47 AM   [ Ignore ]   [ # 30 ]  
Moderator
Avatar
RankRankRankRankRankRankRank
Total Posts:  12779
Joined  04-29-2002
frontflash - 09 July 2005 06:52 AM

ok. there i found the button names. only i can not find the @ (email) <a>(link) buttons. ideas?

Same file . Look for the @ symbol.

<td class='htmlButtonOuter'><div class='htmlButtonInner'><div class='htmlButtonOff'><a href='javascript:promptTag("email");' >&nbsp;@&nbsp;</a></div></div></td>
<
td class='htmlButtonOuter'><div class='htmlButtonInner'><div class='htmlButtonOff'><a href='javascript:promptTag("link");' ><a></a></div></div></td>
<
td class='htmlButtonOuter'><div class='htmlButtonInner'><div class='htmlButtonOff'><a href='javascript:closeall();' >Close Tags</a></div></div></td>

See how it is tied to the promptTag email

You’ll need to get int the javascript part of the page and change the text there.

var email_text    = "Enter the email address";
var
email_title   = "Enter the link title (or leave the field empty to use the email address as the title.)";

 Signature 

Quick Reference - EE Trial Options - EE Wiki - Docs for updating a build

Profile
MSG
 
 
Posted: 09 July 2005 11:55 AM   [ Ignore ]   [ # 31 ]  
Research Assistant
Avatar
RankRankRank
Total Posts:  758
Joined  09-27-2004

thxs


grin

Profile
 
 
Posted: 10 July 2005 03:44 PM   [ Ignore ]   [ # 32 ]  
Research Scientist
Avatar
RankRankRankRankRankRank
Total Posts:  7509
Joined  08-05-2002

Whoops, knew I forgot to change something when I changed the name.  I’ll go take care of that now and upload a new zip.

 Signature 
Profile
 
 
Posted: 10 July 2005 06:05 PM   [ Ignore ]   [ # 33 ]  
Lab Assistant
Avatar
RankRank
Total Posts:  209
Joined  01-10-2004

Actually there’s one more issue with this plugin, or rather the actual core file.  When using the buttons the pages won’t validate XHTML because there is an alt=“whatever” tag inside the href tag along with title= and of course alt is not XHTML compliant in an href tag.

I’m not sure if this is necessary for any other function but if it’s not, it should be removed from the core file.  If it is, then the plugin should automatically remove the alt= when you use it.

 Signature 

bryan | website

Profile
 
 
Posted: 12 July 2005 04:02 PM   [ Ignore ]   [ # 34 ]  
Research Scientist
Avatar
RankRankRankRankRankRank
Total Posts:  7509
Joined  08-05-2002

I will fix that for EE 1.3.1

 Signature 
Profile
 
 
Posted: 12 July 2005 05:43 PM   [ Ignore ]   [ # 35 ]  
Research Assistant
Avatar
RankRankRank
Total Posts:  591
Joined  04-12-2003

Great.  When can we expect 1.3.1 to be released?  j/k

 Signature 

burp.

Profile
 
 
Posted: 12 July 2005 05:49 PM   [ Ignore ]   [ # 36 ]  
Lab Technician
Avatar
RankRankRankRank
Total Posts:  1397
Joined  01-15-2005
bushtit - 12 July 2005 05:43 PM

Great.  When can we expect 1.3.1 to be released?  j/k

soon LOL

 Signature 

EE Duration Tags | {view_count_total}

Profile
 
 
   
2 of 2
2
 
Post Marker Legend
New Topic New posts Hot Topic Hot Topic with new posts New Poll New Poll Moved Topic Moved Topic Sticky Topic Sticky topic
Old Topic No new posts Hot Old Topic Hot Topic with no new posts Old Poll Old Poll Closed Topic Closed Topic Announcement Announcements
Theme
Change Theme
Visitor Statistics
The most visitors ever was 1149, on July 16, 2007 09:33 AM
Total Registered Members: 66467 Total Logged-in Users: 29
Total Topics: 84858 Total Anonymous Users: 12
Total Replies: 455326 Total Guests: 197
Total Posts: 540184    
Members ( View Memberlist )