Bug Report

document.getElementById(“comment_expiration_date”) is null

Date: 10/11/2008 Severity: Trivial
Status: Resolved Reporter: evasion
Version: EE 1.6.4 Assigned To: Not Assigned
Keywords: Control Panel, Publish, Submission Problems, Modules, Comment

Details

Javascript error which block form on Firefox 3 (Mac OS X).

This happens when using date tab in a weblog, but with comment disabled.

This bug seems similar to http://expressionengine.com/bug_tracker/bug/5211/

Comment on Bug Report

Page 1 of 1 pages
Posted by: Derek Jones on 11 October 2008 9:40am
Derek Jones's avatar

Hi evasion, I’m having trouble duplicating and seeing the problem.  Can you walk me through the steps to reveal the error?

Posted by: evasion on 11 October 2008 10:01am
evasion's avatar

In fact after a few test it doesn’t block the form (apologizes), but there’s still a javascript error.

Here’s two hints :

When enabling date tabs with comments disabled there is a javascript error :

document.getElementById(“comment_expiration_date”) is null

I guess the javascript is inserted altough comment are disabled (so comments expiration date isn’t displayed in the date tab).

When disabling both date tabs and comments for a weblog, there’s another javascript error :

update_calendar is not defined

This bug is related here : http://expressionengine.com/bug_tracker/bug/5211/

It’s not really critical, but javascript errors are bad anyway wink

Posted by: evasion on 11 October 2008 10:03am
evasion's avatar

By the way the blocked form problem appeared like this :

- Edit default weblog custom fields preferences
- Changed summary from text area to input text

It automaticly changed char limit to 0.

It’s not really a bug, but a quick fix to automaticly put it to some standard value (ie: 255) would help other people I hope.

Posted by: Derek Jones on 11 October 2008 10:08am
Derek Jones's avatar

Yes, javascript errors are bad, which is why I’m wanting to know the exact steps required to reproduce.  It’s possible that the fix put in place for when the date tab is disabled addresses the issue you’re seeing, but I’d rather not make assumptions.

When you say ‘comments are disabled’, do you mean the “Allow comments in this weblog?” setting in the Weblog Preferences?  Or do you have ‘Display Option Buttons’ set to no in your publish page preferences?

The ‘update_calendar’ error is indeed fixed per the bug report you link to.  However, I still cannot reproduce the error you are seeing, and I’m not certain that they would be related.  What version and build are you using, and are you running any extensions?  When comments are disabled, the comment_expiration_date field is still written, as a hidden input field, so I don’t see how the JS error would occur.

Posted by: evasion on 11 October 2008 10:30am
evasion's avatar

In fact there’s some hidden input named “comment_expiration_date” with no id specified :

<input type=‘hidden’ name=‘comment_expiration_date’ value=’’ />

Steps :
- Edit weblog preferences : Admin›Weblog Administration›Weblog Management›Edit Weblog
- Go to “Comment Posting Preferences”
- Allow comments in this weblog? tick “no”
- Go to “Publish Page Customization”
- Check if “Display Date Fields” is yes
- Go to Publish > new entry, or edit an existing entry.

I’m using latest EE release 1.6.4, latest build (downloaded yesterday to keep it up to date).

Comments module is not installed, but I’ve tried to reinstall it and same problem.

Posted by: Derek Jones on 11 October 2008 1:02pm
Derek Jones's avatar

Thanks evasion, I overlooked a separate fix made in the subversion for this very bug report that was fixed internally.

Name:

Email:

Location:

URL:

Remember my personal information

Notify me of follow-up comments?